Fix dependencies and add support for attachments#3
Open
Fix dependencies and add support for attachments#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
On our project we would like to use this module. Unfortunately there were some broken dependencies.
This PR:
com.sun.mailpackage with theorg.eclipse.angusoneREADME.mdwith the new dependencies to add to the olog'spom.xmlI'm not a Java developer and, since this version currently works as it is for our use case, if changes are needed, we would appreciate them coming directly from the main developers.
Regards,
Giovanni
PS a side note regarding the attachments improvement. A fix on the olog service is needed. In fact, when sending the data to the email-notifier, the olog-service does not add the attachments. The email notifier still works but the attchments are missing. I already implemented a fix on this behavior (on top of v5.1.2) on my fork https://github.com/giosava94/phoebus-olog (branch fix-notify-with-attachment).